Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: optimize the toolbar space and fold the same type of function #5683

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Apr 10, 2024

What type of PR is this?

/kind improvement
/area editor
/milestone 2.15.x

What this PR does / why we need it:

本 PR 对富文本编辑器中工具栏和冒泡菜单进行精简。

  • 对默认富文本冒泡菜单及顶部工具栏相同类型的功能进行了折叠。
  • 删除在 text 的冒泡菜单中,不属于当前选中文本的功能,例如转换为代码块等,这些实际上是段落的功能,并非是文本的功能。而 textAlign 目前也仅仅用在标题和行上,因此也移除。

How to test it?

查看默认富文本编辑器工具栏中,折叠的功能是否正常。选中文本,查看文本中是否不包含段落相关的功能。

Which issue(s) this PR fixes:

Fixes #5669

Does this PR introduce a user-facing change?

对默认富文本编辑器中的工具栏进行折叠及精简优化。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 10, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko April 10, 2024 10:18
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Apr 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby April 10, 2024 10:18
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.48%. Comparing base (5fdf6c0) to head (cede377).
Report is 112 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5683      +/-   ##
============================================
- Coverage     56.91%   56.48%   -0.44%     
- Complexity     3319     3333      +14     
============================================
  Files           587      598      +11     
  Lines         18968    19334     +366     
  Branches       1401     1359      -42     
============================================
+ Hits          10795    10920     +125     
- Misses         7594     7849     +255     
+ Partials        579      565      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ac6896d into halo-dev:main Apr 18, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

折叠默认编辑器悬浮框及工具栏中的同类型功能
3 participants