Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subscription support for expression-based subscribing #5705

Merged
merged 12 commits into from
Apr 26, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 15, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.15.x

What this PR does / why we need it:

通知订阅支持基于表达式订阅

see #5632 for more details

how to test it?

  1. 测试系统通知功能的文章、页面有新评论通知和评论有新回复通知的功能是否正常
  2. 测试 2.14 创建的文章、评论和回复升级到此版本后是否能继续收到相应通知,如文章有新评论

Which issue(s) this PR fixes:

Fixes #5632

Does this PR introduce a user-facing change?

通知订阅支持基于表达式订阅避免订阅随数据量增长同时自动优化之前的订阅数据

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen April 15, 2024 04:19
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 71.71717% with 84 lines in your changes are missing coverage. Please review.

Project coverage is 56.67%. Comparing base (5fdf6c0) to head (15bdc48).
Report is 145 commits behind head on main.

❗ Current head 15bdc48 differs from pull request most recent head 0d9ce0c. Consider uploading reports for the commit 0d9ce0c to get more accurate results

Files Patch % Lines
...n/halo/app/notification/SubscriptionMigration.java 63.01% 26 Missing and 1 partial ⚠️
.../app/core/extension/notification/Subscription.java 0.00% 14 Missing ⚠️
.../infra/ReactiveExtensionPaginatedOperatorImpl.java 72.72% 12 Missing ⚠️
...halo/app/notification/SubscriptionServiceImpl.java 76.19% 7 Missing and 3 partials ⚠️
...lo/app/notification/DefaultNotificationCenter.java 70.96% 7 Missing and 2 partials ⚠️
...n/halo/app/notification/RecipientResolverImpl.java 85.71% 5 Missing and 2 partials ⚠️
...p/notification/DefaultSubscriberEmailResolver.java 75.00% 1 Missing and 1 partial ⚠️
...p/core/extension/reconciler/CommentReconciler.java 0.00% 1 Missing ⚠️
...app/core/extension/reconciler/ReplyReconciler.java 0.00% 1 Missing ⚠️
...ain/java/run/halo/app/notification/Subscriber.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5705      +/-   ##
============================================
- Coverage     56.91%   56.67%   -0.24%     
- Complexity     3319     3421     +102     
============================================
  Files           587      610      +23     
  Lines         18968    20029    +1061     
  Branches       1401     1383      -18     
============================================
+ Hits          10795    11352     +557     
- Misses         7594     8103     +509     
+ Partials        579      574       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the feature/5632 branch 3 times, most recently from 5c2464d to a0bb2b3 Compare April 16, 2024 04:31
@guqing guqing marked this pull request as ready for review April 16, 2024 07:47
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang April 16, 2024 07:47
@guqing guqing force-pushed the feature/5632 branch 2 times, most recently from 649b5d6 to 35cff3a Compare April 18, 2024 10:28
@guqing
Copy link
Member Author

guqing commented Apr 19, 2024

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@guqing guqing force-pushed the feature/5632 branch 2 times, most recently from 58bac57 to 5b8e689 Compare April 24, 2024 04:38
@guqing guqing force-pushed the feature/5632 branch 2 times, most recently from 438fcfe to c2a31d4 Compare April 25, 2024 04:50
@LIlGG
Copy link
Member

LIlGG commented Apr 26, 2024

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It's so awesome.

NB

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@LIlGG
Copy link
Member

LIlGG commented Apr 26, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 0e17d53 into halo-dev:main Apr 26, 2024
8 checks passed
@guqing guqing deleted the feature/5632 branch April 26, 2024 10:32
@JohnNiang JohnNiang modified the milestones: 2.15.x, 2.15.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增强 Subscription 模型以支持表达式匹配
4 participants