-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: subscription support for expression-based subscribing #5705
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5705 +/- ##
============================================
- Coverage 56.91% 56.67% -0.24%
- Complexity 3319 3421 +102
============================================
Files 587 610 +23
Lines 18968 20029 +1061
Branches 1401 1383 -18
============================================
+ Hits 10795 11352 +557
- Misses 7594 8103 +509
+ Partials 579 574 -5 ☔ View full report in Codecov by Sentry. |
5c2464d
to
a0bb2b3
Compare
649b5d6
to
35cff3a
Compare
/hold |
58bac57
to
5b8e689
Compare
438fcfe
to
c2a31d4
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It's so awesome.
NB
Quality Gate passedIssues Measures |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/milestone 2.15.x
What this PR does / why we need it:
通知订阅支持基于表达式订阅
see #5632 for more details
how to test it?
Which issue(s) this PR fixes:
Fixes #5632
Does this PR introduce a user-facing change?