Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize comment reconciliation for better performance and efficiency #5708

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 15, 2024

What type of PR is this?

/kind feature
/milestone 2.15.x
/area core

What this PR does / why we need it:

优化评论数据的调协过程以降低 Halo 启动时评论的调协耗时同时提高性能和资源利用率

Which issue(s) this PR fixes:

Fixes #5707

Does this PR introduce a user-facing change?

优化评论数据的调协过程以降低 Halo 启动时评论的调协耗时同时提高性能和资源利用率

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby April 15, 2024 08:41
@guqing guqing changed the title refactor: optimized comment reconciliation process for enhanced performance and resource utilization refactor: optimize comment reconciliation for better performance and efficiency Apr 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 34.28571% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 56.44%. Comparing base (5fdf6c0) to head (952e06c).
Report is 111 commits behind head on main.

Files Patch % Lines
...ava/run/halo/app/core/extension/content/Reply.java 0.00% 6 Missing ⚠️
...p/core/extension/reconciler/CommentReconciler.java 0.00% 6 Missing ⚠️
...app/core/extension/reconciler/ReplyReconciler.java 0.00% 6 Missing ⚠️
...ain/java/run/halo/app/infra/SchemeInitializer.java 75.00% 2 Missing and 2 partials ⚠️
...a/run/halo/app/core/extension/content/Comment.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5708      +/-   ##
============================================
- Coverage     56.91%   56.44%   -0.47%     
- Complexity     3319     3335      +16     
============================================
  Files           587      598      +11     
  Lines         18968    19367     +399     
  Branches       1401     1362      -39     
============================================
+ Hits          10795    10932     +137     
- Misses         7594     7868     +274     
+ Partials        579      567      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@ruibaby ruibaby merged commit 25339c7 into halo-dev:main Apr 23, 2024
7 of 8 checks passed
@guqing guqing deleted the refactor/5707 branch April 23, 2024 03:29
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化评论控制器的执行次数减少不必要的启动时执行耗时
2 participants