Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support filtering attachments in the library by file media type #5893

Merged
merged 1 commit into from
May 16, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented May 11, 2024

What type of PR is this?

/kind feature
/area core
/area ui

What this PR does / why we need it:

/apis/api.console.halo.run/v1alpha1/attachments 接口增加了 accepts 可选参数,用于根据附件的 MediaType 进行筛选。

为附件库增加通过文件的 MediaType 类型进行筛选的筛选项。

同时支持使用了 CoreSelectorProvider 组件的文件选择框的筛选。现在只会显示 accepts 所支持的文件。

How to test it?

测试 ui 端文件选择框的类型筛选是否正确有效。
测试使用了 CoreSelectorProvider 组件的 accepts 是否有效。

Which issue(s) this PR fixes:

Fixes #5054

Does this PR introduce a user-facing change?

附件库支持按文件类型进行过滤

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu May 11, 2024 06:29
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby May 11, 2024 06:29
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label May 11, 2024
@LIlGG
Copy link
Member Author

LIlGG commented May 11, 2024

/milestone 2.16.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 11, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 56.50%. Comparing base (5fdf6c0) to head (a44c97c).
Report is 167 commits behind head on main.

Files Patch % Lines
...ension/attachment/endpoint/AttachmentEndpoint.java 53.84% 10 Missing and 2 partials ⚠️
...ain/java/run/halo/app/infra/SchemeInitializer.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5893      +/-   ##
============================================
- Coverage     56.91%   56.50%   -0.41%     
- Complexity     3319     3462     +143     
============================================
  Files           587      612      +25     
  Lines         18968    20503    +1535     
  Branches       1401     1419      +18     
============================================
+ Hits          10795    11586     +791     
- Misses         7594     8334     +740     
- Partials        579      583       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit e5bc699 into halo-dev:main May 16, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 16, 2024
@LIlGG LIlGG deleted the feat/attachment-media-type-filter branch May 27, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

附件库支持按文件类型过滤
3 participants