-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support filtering attachments in the library by file media type #5893
feat: support filtering attachments in the library by file media type #5893
Conversation
/milestone 2.16.x |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5893 +/- ##
============================================
- Coverage 56.91% 56.50% -0.41%
- Complexity 3319 3462 +143
============================================
Files 587 612 +25
Lines 18968 20503 +1535
Branches 1401 1419 +18
============================================
+ Hits 10795 11586 +791
- Misses 7594 8334 +740
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/area ui
What this PR does / why we need it:
为
/apis/api.console.halo.run/v1alpha1/attachments
接口增加了accepts
可选参数,用于根据附件的MediaType
进行筛选。为附件库增加通过文件的 MediaType 类型进行筛选的筛选项。
同时支持使用了
CoreSelectorProvider
组件的文件选择框的筛选。现在只会显示accepts
所支持的文件。How to test it?
测试 ui 端文件选择框的类型筛选是否正确有效。
测试使用了
CoreSelectorProvider
组件的accepts
是否有效。Which issue(s) this PR fixes:
Fixes #5054
Does this PR introduce a user-facing change?