Add support for patching extensions #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
|
JohnNiang
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6031 +/- ##
============================================
- Coverage 56.91% 56.36% -0.55%
- Complexity 3319 3570 +251
============================================
Files 587 627 +40
Lines 18968 21132 +2164
Branches 1401 1491 +90
============================================
+ Hits 10795 11912 +1117
- Misses 7594 8614 +1020
- Partials 579 606 +27 ☔ View full report in Codecov by Sentry. |
Signed-off-by: JohnNiang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
#### What type of PR is this? /area ui /kind improvement /milestone 2.17.x #### What this PR does / why we need it: 使用新的 [patch](#6031) 接口重构附件的移动功能。 #### Special notes for your reviewer: 1. 测试附件移动至其他分组的功能是否正常。 2. 测试删除附件分组，选择 **删除并将附件移动至未分组** 选项，观察删除分组之后，其中的附件是否已经移动到未分组。 #### Does this PR introduce a user-facing change? ```release-note None ```
f2c-ci-robot
bot
added
the
release-note
f2c-ci-robot
bot
removed
the
release-note-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area core
/milestone 2.17.x
What this PR does / why we need it:
This PR adds patch method for all extensions API.
Patch example:
http -a admin:admin PATCH http://localhost:8090/apis/plugin.halo.run/v1alpha1/plugins/app-store-integration \ Content-Type:application/json-patch+json \ --raw='[{"op": "replace", "path": "/spec/enabled", "value": false}]'Which issue(s) this PR fixes:
Fixes #2311
Does this PR introduce a user-facing change?