-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing default values for system settings #6035
fix: missing default values for system settings #6035
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6035 +/- ##
============================================
- Coverage 56.91% 56.47% -0.44%
- Complexity 3319 3541 +222
============================================
Files 587 622 +35
Lines 18968 20961 +1993
Branches 1401 1478 +77
============================================
+ Hits 10795 11838 +1043
- Misses 7594 8523 +929
- Partials 579 600 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick release-2.16
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-2.16 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JohnNiang: new pull request created: #6036 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #6035 /assign JohnNiang ```release-note 修复系统设置未保存导致无法正常注册的问题 ```
#### What type of PR is this? /kind bug /area core /milestone 2.16.x #### What this PR does / why we need it: 补充缺失的系统设置默认值。 #### Does this PR introduce a user-facing change? ```release-note 修复系统设置未保存导致无法正常注册的问题 ```
What type of PR is this?
/kind bug
/area core
/milestone 2.16.x
What this PR does / why we need it:
补充缺失的系统设置默认值。
Does this PR introduce a user-facing change?