Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content offset caused by empty slot #6040

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ShiinaKin
Copy link
Contributor

@ShiinaKin ShiinaKin commented Jun 5, 2024

What type of PR is this?

/area ui
/kind improvement

Which issue(s) this PR fixes:

Fixes #5877

修复 Tag 组件的图标为空时,Tag 中的内容没有居中的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jun 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko June 5, 2024 09:32
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby June 5, 2024 09:32
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/ping @halo-dev/sig-halo-console

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
Copy link

f2c-ci-robot bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit f2a0c50 into halo-dev:main Jun 6, 2024
8 checks passed
ruibaby pushed a commit to ruibaby/halo that referenced this pull request Jun 6, 2024
#### What type of PR is this?

/area ui
/kind improvement

#### Which issue(s) this PR fixes:

Fixes halo-dev#5877 

```release-note
修复Tag Icon为空时,后台文章的Tag内容不居中
```
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

后台文章的Tag内容不居中
3 participants