-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move post events into api modules #6052
Conversation
0a4fb97
to
a715a00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6052 +/- ##
============================================
- Coverage 56.91% 56.44% -0.47%
- Complexity 3319 3538 +219
============================================
Files 587 623 +36
Lines 18968 20950 +1982
Branches 1401 1478 +77
============================================
+ Hits 10795 11825 +1030
- Misses 7594 8525 +931
- Partials 579 600 +21 ☔ View full report in Codecov by Sentry. |
a715a00
to
ea9d0d4
Compare
Signed-off-by: JohnNiang <[email protected]>
ea9d0d4
to
6fc6c22
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LIlGG The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/area plugin
What this PR does / why we need it:
Move post events (shared) into api modules for plugin developers. If this PR is merged, I will publish api module into Maven repository(snapshot).
Which issue(s) this PR fixes:
Fixes #5343
Does this PR introduce a user-facing change?