Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move post events into api modules #6052

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Jun 7, 2024

What type of PR is this?

/kind improvement
/area core
/area plugin

What this PR does / why we need it:

Move post events (shared) into api modules for plugin developers. If this PR is merged, I will publish api module into Maven repository(snapshot).

Which issue(s) this PR fixes:

Fixes #5343

Does this PR introduce a user-facing change?

将文章相关的事件移动至 api 模块以暴露给插件使用。

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider labels Jun 7, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen June 7, 2024 09:31
@JohnNiang JohnNiang force-pushed the refactor/post-events branch from 0a4fb97 to a715a00 Compare June 7, 2024 09:36
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 56.44%. Comparing base (5fdf6c0) to head (6fc6c22).
Report is 230 commits behind head on main.

Files Patch % Lines
...n/halo/app/event/post/PostVisibleChangedEvent.java 0.00% 6 Missing ⚠️
...java/run/halo/app/event/post/PostDeletedEvent.java 0.00% 4 Missing ⚠️
...c/main/java/run/halo/app/event/post/PostEvent.java 0.00% 4 Missing ⚠️
...va/run/halo/app/event/post/PostPublishedEvent.java 0.00% 2 Missing ⚠️
.../run/halo/app/event/post/PostUnpublishedEvent.java 0.00% 2 Missing ⚠️
...java/run/halo/app/event/post/PostUpdatedEvent.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6052      +/-   ##
============================================
- Coverage     56.91%   56.44%   -0.47%     
- Complexity     3319     3538     +219     
============================================
  Files           587      623      +36     
  Lines         18968    20950    +1982     
  Branches       1401     1478      +77     
============================================
+ Hits          10795    11825    +1030     
- Misses         7594     8525     +931     
- Partials        579      600      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang JohnNiang force-pushed the refactor/post-events branch from a715a00 to ea9d0d4 Compare June 7, 2024 09:44
@JohnNiang JohnNiang force-pushed the refactor/post-events branch from ea9d0d4 to 6fc6c22 Compare June 7, 2024 10:11
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
Copy link

f2c-ci-robot bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LIlGG
Once this PR has been reviewed and has the lgtm label, please ask for approval from johnniang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit b692db1 into halo-dev:main Jun 7, 2024
7 of 8 checks passed
@JohnNiang JohnNiang deleted the refactor/post-events branch June 7, 2024 10:36
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 14, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

完善事件机制并开放给开发者
3 participants