Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure pasted content auto-generates title id #6059

Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 11, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.17.x

What this PR does / why we need it:

当前在编辑器中粘贴内容后,如果不修改任意标题或新增标题,则无法为当前标题自动生成标题 ID,进而导致锚点失效。

本 PR 将在编辑器触发内容更改后,如果是粘贴的内容,则直接触发生成标题 ID。

How to test it?

新建一篇文章并粘贴一段带标题的内容后直接发布。

查看发布后的文章是否可以在主题端使用锚点跳转。

Which issue(s) this PR fixes:

Fixes #6056

Does this PR introduce a user-facing change?

解决在默认编辑器中粘贴的内容无法生成标题 ID 的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove June 11, 2024 06:57
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (5fdf6c0) to head (a90a37e).
Report is 233 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6059      +/-   ##
============================================
- Coverage     56.91%   56.44%   -0.47%     
- Complexity     3319     3538     +219     
============================================
  Files           587      623      +36     
  Lines         18968    20950    +1982     
  Branches       1401     1478      +77     
============================================
+ Hits          10795    11825    +1030     
- Misses         7594     8525     +931     
- Partials        579      600      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@guqing
Copy link
Member

guqing commented Jun 17, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 10f3157 into halo-dev:main Jun 17, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

复制粘贴的文章,无法通过目录到文章对应位置
3 participants