Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default editor focus setting failure #6062

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 11, 2024

What type of PR is this?

/kind bug
/area editor
/area ui

What this PR does / why we need it:

当前为默认编辑器设置焦点的时机放在 onMounted 时,但此时默认编辑器可能还未加载成功且标题也为能成功加载,因此无法保证正确设置标题焦点。

当前 PR 将此时机放置在默认编辑器创建完成之后的 onCreate ,此时将能够保证焦点设置成功。

How to test it?

测试默认编辑器能否正常设置标题或内容的焦点。

Which issue(s) this PR fixes:

Fixes #6060

Does this PR introduce a user-facing change?

解决使用默认编辑器时无法正确设置焦点的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko June 11, 2024 07:52
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing June 11, 2024 07:52
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jun 11, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Jun 11, 2024

/milestone 2.17.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 11, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (5fdf6c0) to head (d78cbce).
Report is 233 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6062      +/-   ##
============================================
- Coverage     56.91%   56.44%   -0.47%     
- Complexity     3319     3538     +219     
============================================
  Files           587      623      +36     
  Lines         18968    20950    +1982     
  Branches       1401     1478      +77     
============================================
+ Hits          10795    11825    +1030     
- Misses         7594     8525     +931     
- Partials        579      600      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG LIlGG requested a review from ruibaby June 11, 2024 08:01
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3076838 into halo-dev:main Jun 14, 2024
8 checks passed
@LIlGG LIlGG deleted the fix/setting-title-focus-error branch June 14, 2024 08:37
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

进入新文章页面时会报错
3 participants