-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default editor focus setting failure #6062
fix: default editor focus setting failure #6062
Conversation
/milestone 2.17.x |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6062 +/- ##
============================================
- Coverage 56.91% 56.44% -0.47%
- Complexity 3319 3538 +219
============================================
Files 587 623 +36
Lines 18968 20950 +1982
Branches 1401 1478 +77
============================================
+ Hits 10795 11825 +1030
- Misses 7594 8525 +931
- Partials 579 600 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area editor
/area ui
What this PR does / why we need it:
当前为默认编辑器设置焦点的时机放在
onMounted
时,但此时默认编辑器可能还未加载成功且标题也为能成功加载,因此无法保证正确设置标题焦点。当前 PR 将此时机放置在默认编辑器创建完成之后的
onCreate
,此时将能够保证焦点设置成功。How to test it?
测试默认编辑器能否正常设置标题或内容的焦点。
Which issue(s) this PR fixes:
Fixes #6060
Does this PR introduce a user-facing change?