Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a verified email can be reused #6064

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 11, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.17.x

What this PR does / why we need it:

修复已验证邮箱可以重复的问题

如果出现多个重复的已验证邮箱,则只保留一个其他的设置为未验证

Does this PR introduce a user-facing change?

修复已验证邮箱可以重复的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG June 11, 2024 09:19
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 40 lines in your changes missing coverage. Please review.

Project coverage is 56.40%. Comparing base (5fdf6c0) to head (519a78a).
Report is 239 commits behind head on main.

Files Patch % Lines
...ion/service/impl/EmailVerificationServiceImpl.java 0.00% 22 Missing ⚠️
.../app/core/extension/reconciler/UserReconciler.java 23.52% 12 Missing and 1 partial ⚠️
...lo/app/core/extension/service/UserServiceImpl.java 0.00% 4 Missing ⚠️
...ain/java/run/halo/app/infra/SchemeInitializer.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6064      +/-   ##
============================================
- Coverage     56.91%   56.40%   -0.51%     
- Complexity     3319     3542     +223     
============================================
  Files           587      623      +36     
  Lines         18968    20990    +2022     
  Branches       1401     1482      +81     
============================================
+ Hits          10795    11839    +1044     
- Misses         7594     8549     +955     
- Partials        579      602      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the refactor/email-verify branch from 8940a35 to df05beb Compare June 14, 2024 04:17
@guqing guqing force-pushed the refactor/email-verify branch from df05beb to d3fece5 Compare June 14, 2024 04:19
@guqing guqing marked this pull request as ready for review June 14, 2024 04:20
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 6d3a157 into halo-dev:main Jun 20, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 20, 2024
@guqing guqing deleted the refactor/email-verify branch June 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants