Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import and export theme configuration #6071

Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 12, 2024

What type of PR is this?

/kind feature
/area ui
/milestone 2.17.x

What this PR does / why we need it:

为主题增加导入及导出配置的功能。

image

How to test it?

测试主题导入及导出功能是否正常可用。
测试当前主题下的不同版本导入导出后数据是否正常。
测试在当前主题下使用其他主题导出的配置是否会报错。

Which issue(s) this PR fixes:

Fixes #1073

Does this PR introduce a user-facing change?

为单个主题配置增加导入与导出的功能。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko June 12, 2024 04:16
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jun 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby June 12, 2024 04:16
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (5fdf6c0) to head (90ea121).
Report is 237 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6071      +/-   ##
============================================
- Coverage     56.91%   56.45%   -0.46%     
- Complexity     3319     3540     +221     
============================================
  Files           587      623      +36     
  Lines         18968    20956    +1988     
  Branches       1401     1478      +77     
============================================
+ Hits          10795    11831    +1036     
- Misses         7594     8525     +931     
- Partials        579      600      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby requested review from JohnNiang and guqing and removed request for Aanko June 12, 2024 10:12
Signed-off-by: Ryan Wang <[email protected]>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
Copy link

f2c-ci-robot bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b445b50 into halo-dev:main Jun 19, 2024
6 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 提供单个主题设置的导入导出功能。
2 participants