-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for publishing events among plugins #6081
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6081 +/- ##
============================================
- Coverage 56.91% 56.48% -0.43%
- Complexity 3319 3549 +230
============================================
Files 587 625 +38
Lines 18968 20981 +2013
Branches 1401 1484 +83
============================================
+ Hits 10795 11852 +1057
- Misses 7594 8527 +933
- Partials 579 602 +23 ☔ View full report in Codecov by Sentry. |
7112a06
to
0df68f2
Compare
Quality Gate passedIssues Measures |
@JohnNiang 是否需要补充一下插件开发的文档? |
目前确实缺少相关的文档,稍后我完善一下。 |
Signed-off-by: JohnNiang <[email protected]>
0df68f2
to
8c40bf4
Compare
提个 PR 到 halo-dev/docs 吧。 8c40bf4#diff-b8447709f93eeedfadb44f95a9c5fd9f508c8a48c446b9df0f5022722df2992d |
Co-authored-by: guqing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/area plugin
What this PR does / why we need it:
This PR enhance usage of SharedEvent annotation to add support for publishing events among plugins.
How to test?
Clone repository https://github.com/halo-dev/plugin-starter
Change build.gradle as following:
Change StarterPlugin as following:
Add a listener to Halo core
Does this PR introduce a user-facing change?