-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor search engine and improve document extensibility #6082
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6082 +/- ##
============================================
+ Coverage 54.51% 56.96% +2.45%
- Complexity 3523 3704 +181
============================================
Files 646 652 +6
Lines 21862 22039 +177
Branches 1528 1537 +9
============================================
+ Hits 11917 12555 +638
+ Misses 9328 8879 -449
+ Partials 617 605 -12 ☔ View full report in Codecov by Sentry. |
107597f
to
b52954d
Compare
e8f57b8
to
142b951
Compare
Signed-off-by: JohnNiang <[email protected]>
142b951
to
0f148e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/kind api-change
/area core
What this PR does / why we need it:
See https://github.com/JohnNiang/halo/blob/refactor/search/docs/extension-points/search-engine.md for more
Which issue(s) this PR fixes:
Fixes #5202
Fixes #5339
Fixes #5613
Fixes #5172
Fixes #4796
Fixes #5625
Fixes #5805
Special notes for your reviewer:
Does this PR introduce a user-facing change?