Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor search engine and improve document extensibility #6082

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Jun 14, 2024

What type of PR is this?

/kind improvement
/kind api-change
/area core

What this PR does / why we need it:

See https://github.com/JohnNiang/halo/blob/refactor/search/docs/extension-points/search-engine.md for more

Which issue(s) this PR fixes:

Fixes #5202
Fixes #5339
Fixes #5613
Fixes #5172
Fixes #4796
Fixes #5625
Fixes #5805

Special notes for your reviewer:

Does this PR introduce a user-facing change?

重构搜索引擎并提高可扩展性。

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Jun 14, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby June 14, 2024 09:50
@f2c-ci-robot f2c-ci-robot bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/core Issues or PRs related to the Halo Core labels Jun 14, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 80.94059% with 77 lines in your changes missing coverage. Please review.

Project coverage is 56.96%. Comparing base (bc10336) to head (0f148e1).
Report is 3 commits behind head on main.

Files Patch % Lines
...run/halo/app/search/lucene/LuceneSearchEngine.java 86.05% 20 Missing and 9 partials ⚠️
...rc/main/java/run/halo/app/search/HaloDocument.java 0.00% 17 Missing ⚠️
...rc/main/java/run/halo/app/search/SearchOption.java 0.00% 14 Missing ⚠️
...nfra/exception/RequestBodyValidationException.java 14.28% 6 Missing ⚠️
.../app/search/event/HaloDocumentAddRequestEvent.java 0.00% 4 Missing ⚠️
...p/search/event/HaloDocumentDeleteRequestEvent.java 0.00% 4 Missing ⚠️
.../search/event/HaloDocumentRebuildRequestEvent.java 0.00% 2 Missing ⚠️
...rc/main/java/run/halo/app/search/SearchResult.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6082      +/-   ##
============================================
+ Coverage     54.51%   56.96%   +2.45%     
- Complexity     3523     3704     +181     
============================================
  Files           646      652       +6     
  Lines         21862    22039     +177     
  Branches       1528     1537       +9     
============================================
+ Hits          11917    12555     +638     
+ Misses         9328     8879     -449     
+ Partials        617      605      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang JohnNiang force-pushed the refactor/search branch 3 times, most recently from 107597f to b52954d Compare June 18, 2024 16:26
@f2c-ci-robot f2c-ci-robot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 25, 2024
@JohnNiang JohnNiang changed the title WIP: Refactor search engine extension Refactor search engine and improve document extensibility Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link

f2c-ci-robot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 632bb69 into halo-dev:main Jun 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
2 participants