refactor: remove page cache feature #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
the
kind/api-change
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
f2c-ci-robot
bot
removed
the
needs-rebase
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Ryan Wang <[email protected]>
ruibaby
force-pushed
the
refactor/remove-page-cache-feature
branch
from
8a0b400 to
21ec5d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6108 +/- ##
============================================
+ Coverage 54.51% 57.16% +2.65%
- Complexity 3523 3709 +186
============================================
Files 646 647 +1
Lines 21862 21947 +85
Branches 1528 1534 +6
============================================
+ Hits 11917 12546 +629
+ Misses 9328 8794 -534
+ Partials 617 607 -10 ☔ View full report in Codecov by Sentry. |
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jul 1, 2024
f2c-ci-robot bot
referenced
this pull request
in halo-dev/docs
Jul 1, 2024
移除部署文章的 `halo.cache.page.disabled` 参数，在 2.17 中已经[移除此功能](https://github.com/halo-dev/halo/pull/6108)，后续将由 https://github.com/halo-sigs/plugin-page-cache 提供此功能。 /kind documentation ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area core
/kind api-change
/milestone 2.17.x
What this PR does / why we need it:
移除内置的页面静态缓存功能，后续将由 https://github.com/halo-sigs/plugin-page-cache 插件提供。
Which issue(s) this PR fixes:
Fixes #5639
Special notes for your reviewer:
Does this PR introduce a user-facing change?