Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not remembering the selected attachment policy in upload modal #6115

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 21, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.17.x

What this PR does / why we need it:

修复首次上传附件时,没有默认选择第一个存储策略的问题。

Which issue(s) this PR fixes:

Fixes #6094

Does this PR introduce a user-facing change?

修复首次上传附件时,没有默认选择第一个存储策略的问题。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 21, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 21, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and QuentinHsu June 21, 2024 08:13
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jun 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ae7dcbb into halo-dev:main Jun 23, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 23, 2024
@ruibaby ruibaby deleted the fix/attachment-policy-store branch June 25, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

首次访问附件库上传,没有默认选择第一项存储策略
3 participants