-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: range selection feature to default editor #6117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6117 +/- ##
============================================
- Coverage 56.91% 54.68% -2.23%
- Complexity 3319 3427 +108
============================================
Files 587 629 +42
Lines 18968 21209 +2241
Branches 1401 1482 +81
============================================
+ Hits 10795 11599 +804
- Misses 7594 9019 +1425
- Partials 579 591 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area editor
/milestone 2.17.x
What this PR does / why we need it:
为默认编辑器添加
RangeSelection
选择器。它的功能基本与 TextSelection 相反,例如:
RangeSelection
可以用于范围选中块节点并进行操作,可用于全选内容并进行删除操作。How to test it?
测试使用点击,拖拽,释放鼠标的操作,能否选中某些节点。
测试删除选中的节点。
Which issue(s) this PR fixes:
Fixes #5194
Does this PR introduce a user-facing change?