-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump mariadb driver to 1.2.1 to fix crash issue #6133
Conversation
Signed-off-by: Ryan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6133 +/- ##
============================================
- Coverage 56.91% 54.68% -2.23%
- Complexity 3319 3427 +108
============================================
Files 587 629 +42
Lines 18968 21209 +2241
Branches 1401 1482 +81
============================================
+ Hits 10795 11599 +804
- Misses 7594 9019 +1425
- Partials 579 591 +12 ☔ View full report in Codecov by Sentry. |
使用 MariaDB 原生驱动无法启动的问题将在 halo-dev/halo#6133 中修复,并发布到 2.17.0,所以移除此提示。 /kind documentation ```release-note None ```
What type of PR is this?
/area core
/kind bug
/milestone 2.17.x
What this PR does / why we need it:
升级 MariaDB 的原生驱动版本至 1.2.1,以解决无法正常部署的问题。
Which issue(s) this PR fixes:
Fixes #5534
Special notes for your reviewer:
测试方式:
./gradlew clean build -x check -x test --refresh-dependencies
docker build -t halohub/halo:mariadb-fix .
Does this PR introduce a user-facing change?