Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add management and view pages for extension points #6137

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 25, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.17.x

What this PR does / why we need it:

添加扩展点的查看和设置页面。

image

Which issue(s) this PR fixes:

Fixes #3206

Does this PR introduce a user-facing change?

添加系统扩展点的查看和设置页面。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang June 25, 2024 07:51
@ruibaby ruibaby changed the title feat: add management and view pages for extension points WIP: feat: add management and view pages for extension points Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.09%. Comparing base (5fdf6c0) to head (19df7ff).
Report is 282 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6137      +/-   ##
============================================
- Coverage     56.91%   55.09%   -1.82%     
- Complexity     3319     3492     +173     
============================================
  Files           587      635      +48     
  Lines         18968    21393    +2425     
  Branches       1401     1496      +95     
============================================
+ Hits          10795    11786     +991     
- Misses         7594     9002    +1408     
- Partials        579      605      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby changed the title WIP: feat: add management and view pages for extension points feat: add management and view pages for extension points Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

awsome works

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link

f2c-ci-robot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 5eabce7 into halo-dev:main Jun 26, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化评论扩展点实现类的使用允许用户通过设置选择
3 participants