-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add list options for sync all synchronizer #6145
Conversation
4a76a89
to
f285d6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6145 +/- ##
============================================
- Coverage 56.91% 54.75% -2.16%
- Complexity 3319 3432 +113
============================================
Files 587 630 +43
Lines 18968 21198 +2230
Branches 1401 1483 +82
============================================
+ Hits 10795 11607 +812
- Misses 7594 9001 +1407
- Partials 579 590 +11 ☔ View full report in Codecov by Sentry. |
f285d6c
to
1d3a415
Compare
/hold |
1d3a415
to
283a686
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
### What this PR does? 补充关于定制和构建控制器的文档 see also halo-dev/halo#6145 ```release-note None ```
What type of PR is this?
/kind improvement
/area core
/milestone 2.17.x
What this PR does / why we need it:
为启动时同步添加 ListOptions 选项为后续保持 ExtensionMatcher 的纯粹做准备,后续将移除 ExtensionMatcher 中多余的方法声明,只保留 match 方法,最终的结果希望是
以前构建 Controller 的写法
现在的写法
Does this PR introduce a user-facing change?