Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic list input #6146

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 26, 2024

What type of PR is this?

/kind feature
/area ui
/milestone 2.17.x

What this PR does / why we need it:

为 formkit 增加动态列表的 input。

使用方式:

- $formkit: list
  name: users
  label: Users
  addLabel: Add User
  min: 1
  max: 3
  itemType: string
  children:
    - $formkit: text
      index: "$index"
      validation: required

Note

list 组件有且只有一个子节点,并且必须为子节点传递 index 属性。若想提供多个字段,则建议使用 group 组件包裹。

How to test it?

测试动态数组是否正常可用。保存的结果是否为 {users: ["", ""]}

Which issue(s) this PR fixes:

Fixes #6098

Does this PR introduce a user-facing change?

为 Formkit 增加动态列表的组件

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and ruibaby June 26, 2024 03:33
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.04%. Comparing base (5fdf6c0) to head (93e11ac).
Report is 268 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6146      +/-   ##
============================================
- Coverage     56.91%   55.04%   -1.88%     
- Complexity     3319     3490     +171     
============================================
  Files           587      635      +48     
  Lines         18968    21388    +2420     
  Branches       1401     1496      +95     
============================================
+ Hits          10795    11772     +977     
- Misses         7594     9010    +1416     
- Partials        579      606      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5d5df7c into halo-dev:main Jun 26, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 26, 2024
@LIlGG LIlGG deleted the feat/add-dynamic-list branch June 27, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望 FormKit 的 list 输入框能支持动态添加元素
3 participants