-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add builder for list options #6148
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6148 +/- ##
============================================
- Coverage 56.91% 55.13% -1.78%
- Complexity 3319 3458 +139
============================================
Files 587 629 +42
Lines 18968 21234 +2266
Branches 1401 1491 +90
============================================
+ Hits 10795 11707 +912
- Misses 7594 8924 +1330
- Partials 579 603 +24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
### What this PR does? 添加 ListOptions builder 的文档说明 see also halo-dev/halo#6148 ```release-note None ```
What type of PR is this?
/kind improvement
/area core
/milestone 2.17.x
What this PR does / why we need it:
为 ListOptions 增加 Builder 以方便构建 ListOptions 对象,可以通过以下形式创建
Does this PR introduce a user-facing change?