pref: editor iframe risk with src tag #6150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
============================================
- Coverage 56.91% 55.08% -1.83%
- Complexity 3319 3490 +171
============================================
Files 587 635 +48
Lines 18968 21388 +2420
Branches 1401 1496 +95
============================================
+ Hits 10795 11781 +986
- Misses 7594 9002 +1408
- Partials 579 605 +26 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area editor
/milestone 2.17.x
What this PR does / why we need it:
在用户设置 iframe 相关的 src 时，检测设置的链接是否符合白名单。如果不符合则不允许设置。
see ueberdosis/tiptap#5160
How to test it?
测试在 iframe 中的 src 输入
javascript: alert("1")时是否会触发 javascriptDoes this PR introduce a user-facing change?