Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spelling errors in sorting criteria for query categories #6173

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 27, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.17.x

What this PR does / why we need it:

修复查询分类的排序条件拼写错误导致的错误

Which issue(s) this PR fixes:

Fixes #6171

Does this PR introduce a user-facing change?

修复查询分类的排序条件拼写错误导致的错误

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 27, 2024 08:40
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.95%. Comparing base (bc10336) to head (1b34a75).
Report is 11 commits behind head on main.

Files Patch % Lines
...un/halo/app/theme/finders/impl/PostFinderImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6173      +/-   ##
============================================
+ Coverage     54.51%   56.95%   +2.44%     
- Complexity     3523     3704     +181     
============================================
  Files           646      652       +6     
  Lines         21862    22038     +176     
  Branches       1528     1537       +9     
============================================
+ Hits          11917    12552     +635     
+ Misses         9328     8880     -448     
+ Partials        617      606      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link

f2c-ci-robot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 4d6450d into halo-dev:main Jun 27, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

升级 2.17 后 postFinder.listByCategory() 报错
3 participants