Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: add folding function to code blocks #6177

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 27, 2024

What type of PR is this?

/kind improvement
/area editor
/milestone 2.17.x

What this PR does / why we need it:

为默认编辑器代码块增加折叠功能。

image

How to test it?

测试折叠功能是否可用。
测试重新打开文章之后代码块是否仍旧处于折叠状态。

Which issue(s) this PR fixes:

Fixes #6166

Does this PR introduce a user-facing change?

为默认编辑器代码块增加折叠功能

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/editor Issues or PRs related to the Editor labels Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby June 27, 2024 09:24
@LIlGG LIlGG force-pushed the pref/code-block-fold branch from 730ee47 to 099bf04 Compare June 27, 2024 09:26
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (bc10336) to head (099bf04).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6177      +/-   ##
============================================
+ Coverage     54.51%   56.92%   +2.41%     
- Complexity     3523     3704     +181     
============================================
  Files           646      652       +6     
  Lines         21862    22038     +176     
  Branches       1528     1537       +9     
============================================
+ Hits          11917    12546     +629     
+ Misses         9328     8886     -442     
+ Partials        617      606      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

如果折叠之后能够保留头部 10 行就更好了。

Copy link

f2c-ci-robot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@ruibaby
Copy link
Member

ruibaby commented Jun 27, 2024

/approve

如果折叠之后能够保留头部 10 行就更好了。

/assign @JohnNiang

@f2c-ci-robot f2c-ci-robot bot merged commit ab14157 into halo-dev:main Jun 27, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望默认编辑器中的代码块能够支持折叠
3 participants