Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for setting an owner for posts #6178

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 27, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.17.x

What this PR does / why we need it:

支持手动为文章设置作者。

image

Which issue(s) this PR fixes:

Fixes #5720

Special notes for your reviewer:

需要测试:

  1. 打开任意文章的设置,在高级中设置作者并保存,观察是否成功。
  2. 选择一批文章,点击批量设置,设置一个作者,观察是否设置成功。

Does this PR introduce a user-facing change?

支持手动为文章设置作者。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui June 27, 2024 09:30
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu June 27, 2024 09:30
Signed-off-by: Ryan Wang <[email protected]>
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.96%. Comparing base (bc10336) to head (2a0d631).
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6178      +/-   ##
============================================
+ Coverage     54.51%   56.96%   +2.45%     
- Complexity     3523     3704     +181     
============================================
  Files           646      652       +6     
  Lines         21862    22038     +176     
  Branches       1528     1537       +9     
============================================
+ Hits          11917    12555     +638     
+ Misses         9328     8878     -450     
+ Partials        617      605      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby requested review from JohnNiang, LIlGG and guqing and removed request for QuentinHsu and lan-yonghui June 27, 2024 09:46
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit bb0a3bc into halo-dev:main Jun 27, 2024
7 checks passed
@ruibaby ruibaby deleted the feat/post-owner branch June 27, 2024 10:13
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章作者转让功能
3 participants