Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restrict deletion of the primary menu #6203

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 28, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.17.x

What this PR does / why we need it:

添加对菜单的限制,不能删除已经设置为主菜单的菜单。

Which issue(s) this PR fixes:

Fixes #4956

Does this PR introduce a user-facing change?

添加对菜单的限制,不能删除已经设置为主菜单的菜单。

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/ui Issues or PRs related to the Halo UI labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG June 28, 2024 07:27
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
Copy link

f2c-ci-robot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.06%. Comparing base (bc10336) to head (26e0bf6).
Report is 26 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6203      +/-   ##
============================================
+ Coverage     54.51%   57.06%   +2.55%     
- Complexity     3523     3717     +194     
============================================
  Files           646      651       +5     
  Lines         21862    22041     +179     
  Branches       1528     1542      +14     
============================================
+ Hits          11917    12577     +660     
+ Misses         9328     8858     -470     
+ Partials        617      606      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit 80e1110 into halo-dev:main Jun 28, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

菜单删除后,前台空白
2 participants