Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slug generation rules to post saving feature in the post editing page #6205

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 28, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.17.x

What this PR does / why we need it:

支持在文章编辑页面创建文章时,也应用别名生成规则

Which issue(s) this PR fixes:

Fixes #5118
Fixes #6155

Special notes for your reviewer:

Does this PR introduce a user-facing change?

支持在文章编辑页面创建文章时,也应用别名生成规则

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen June 28, 2024 07:41
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove June 28, 2024 07:41
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.06%. Comparing base (bc10336) to head (fc2f252).
Report is 31 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6205      +/-   ##
============================================
+ Coverage     54.51%   57.06%   +2.55%     
- Complexity     3523     3717     +194     
============================================
  Files           646      651       +5     
  Lines         21862    22041     +179     
  Branches       1528     1542      +14     
============================================
+ Hits          11917    12577     +660     
+ Misses         9328     8858     -470     
+ Partials        617      606      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2024
Copy link

f2c-ci-robot bot commented Jun 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit c1ca8d1 into halo-dev:main Jun 29, 2024
7 checks passed
@ruibaby ruibaby deleted the feat/generate-slug branch June 29, 2024 16:39
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章别名生成策略选择short uuid未生效 文章设置别名生成策略问题
2 participants