Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: causing API to be pending when plugin startup encounters an error #6207

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 28, 2024

What type of PR is this?

/kind improvement
/area core
/area plugin

What this PR does / why we need it:

修复当启动插件遇到 Error 级别的错误时会导致 API 被挂起无法终止的问题

- Throwable
    - Error
    - Exception

see #6192 for more details

Which issue(s) this PR fixes:

Fixes #6192

Does this PR introduce a user-facing change?

修复当启动插件遇到 Error 级别的错误时会导致 API 被挂起无法终止的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen June 28, 2024 08:33
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider labels Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (bc10336) to head (5c15ce9).
Report is 32 commits behind head on main.

Files Patch % Lines
...pp/core/extension/reconciler/PluginReconciler.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6207      +/-   ##
============================================
+ Coverage     54.51%   57.04%   +2.53%     
- Complexity     3523     3717     +194     
============================================
  Files           646      651       +5     
  Lines         21862    22041     +179     
  Branches       1528     1542      +14     
============================================
+ Hits          11917    12574     +657     
+ Misses         9328     8860     -468     
+ Partials        617      607      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jun 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 8e97814 into halo-dev:main Jun 29, 2024
7 checks passed
@ruibaby ruibaby added this to the 2.17.0 milestone Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化插件启动失败时的重试机制
3 participants