-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add disabled state styling to checkboxes #6220
feat: add disabled state styling to checkboxes #6220
Conversation
@longjuan: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area ui |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6220 +/- ##
============================================
+ Coverage 54.51% 57.16% +2.65%
- Complexity 3523 3717 +194
============================================
Files 646 647 +1
Lines 21862 21968 +106
Branches 1528 1536 +8
============================================
+ Hits 11917 12558 +641
+ Misses 9328 8800 -528
+ Partials 617 610 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind improvement
What this PR does / why we need it:
当前多选框disabled与非disabled样式上无区别,不好分辨。
Which issue(s) this PR fixes:
Fixes #5974
Special notes for your reviewer:
Does this PR introduce a user-facing change?