Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disabled state styling to checkboxes #6220

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Jun 30, 2024

What type of PR is this?

/area ui
/kind improvement

What this PR does / why we need it:

当前多选框disabled与非disabled样式上无区别,不好分辨。

Which issue(s) this PR fixes:

Fixes #5974

Special notes for your reviewer:

image

Does this PR introduce a user-facing change?

增加多选框disabled样式

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 30, 2024
Copy link

f2c-ci-robot bot commented Jun 30, 2024

@longjuan: The label(s) kind/ui cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind ui
/kind improvement

What this PR does / why we need it:

当前多选框disabled与非disabled样式上无区别,不好分辨。

Which issue(s) this PR fixes:

Fixes #5974

Special notes for your reviewer:

image

Does this PR introduce a user-facing change?

增加多选框disabled样式

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove June 30, 2024 08:21
@longjuan
Copy link
Member Author

/area ui

@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.16%. Comparing base (bc10336) to head (50080ba).
Report is 35 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6220      +/-   ##
============================================
+ Coverage     54.51%   57.16%   +2.65%     
- Complexity     3523     3717     +194     
============================================
  Files           646      647       +1     
  Lines         21862    21968     +106     
  Branches       1528     1536       +8     
============================================
+ Hits          11917    12558     +641     
+ Misses         9328     8800     -528     
+ Partials        617      610       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@ruibaby ruibaby added this to the 2.17.x milestone Jul 1, 2024
Copy link

f2c-ci-robot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2c454cc into halo-dev:main Jul 1, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

原生input标签的disabled样式缺失
2 participants