Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag and category add save and continue button #6223

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

LonelySnowman
Copy link
Contributor

@LonelySnowman LonelySnowman commented Jun 30, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

文章分类和标签 Modal 添加 ”保存并继续添加” 按钮,便于连续添加。

Which issue(s) this PR fixes:

Fixes #6127

Special notes for your reviewer:

image

Does this PR introduce a user-facing change?

文章分类和标签的编辑表单支持保存并继续添加。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 30, 2024
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2024

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and LIlGG June 30, 2024 10:37
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.05%. Comparing base (bc10336) to head (85c16cf).
Report is 54 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6223      +/-   ##
============================================
+ Coverage     54.51%   58.05%   +3.54%     
- Complexity     3523     3757     +234     
============================================
  Files           646      649       +3     
  Lines         21862    22022     +160     
  Branches       1528     1547      +19     
============================================
+ Hits          11917    12785     +868     
+ Misses         9328     8618     -710     
- Partials        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Copy link
Member

ruibaby commented Jul 1, 2024

感谢参与贡献,这里有两个体验的问题:

  1. 提交的时候两个按钮都会有加载状态,期望只显示一个。可以考虑在按钮的 loading 属性上也加上 keepAddingSubmit 条件。

    image
  2. 保存并继续添加 按钮建议放在提交旁边,如果三个按钮同时放在一起不好看,可以考虑将 取消 按钮放置在最右边,类似于:

    <div class="flex justify-between">
       <VSpace>
         <VButton>提交</VButton>
         <VButton>提交并继续添加</VButton>
       </VSpace>
       <VButtion>关闭</VButton>
    </div>

@LonelySnowman
Copy link
Contributor Author

@ruibaby 在一个按钮 loading 过程中需要对另一个按钮禁用么,如果用户在一个按钮加载时又去触发另一个按钮会导致表单提交两次。

@ruibaby
Copy link
Member

ruibaby commented Jul 1, 2024

@ruibaby 在一个按钮 loading 过程中需要对另一个按钮禁用么,如果用户在一个按钮加载时又去触发另一个按钮会导致表单提交两次。

那可以直接给按钮的 disabled 属性设置 saving。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link

f2c-ci-robot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@ruibaby ruibaby added this to the 2.17.0 milestone Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit c5bf192 into halo-dev:main Jul 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望能在新增文章分类及标签时有一个能“保存并继续”的功能
3 participants