Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin detail modal as global component #6233

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 1, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.17.x

What this PR does / why we need it:

添加 PluginDetailModal,用于打开插件的设置界面。并在扩展设置页面适配以测试。

image

Which issue(s) this PR fixes:

Fixes #6232

Does this PR introduce a user-facing change?

为 UI 添加通用的插件设置弹窗,以供插件主动调用

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang July 1, 2024 06:26
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG July 1, 2024 06:26
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.18%. Comparing base (bc10336) to head (79a872b).
Report is 46 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6233      +/-   ##
============================================
+ Coverage     54.51%   57.18%   +2.67%     
- Complexity     3523     3720     +197     
============================================
  Files           646      648       +2     
  Lines         21862    21979     +117     
  Branches       1528     1538      +10     
============================================
+ Hits          11917    12569     +652     
+ Misses         9328     8801     -527     
+ Partials        617      609       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link

f2c-ci-robot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 2aaf64a into halo-dev:main Jul 1, 2024
7 checks passed
@ruibaby ruibaby deleted the feat/add-plugin-detail-modal branch July 1, 2024 08:59
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望提供一个通用的插件设置弹窗,以供插件主动调用
3 participants