Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin to listen the event the plugin has started #6234

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature
/area core
/milestone 2.17.x

What this PR does / why we need it:

This PR add support for allowing plugin to listen the event that the plugin has started. Below is an example of listening the event in plugin:

    @EventListener
    void onPluginStartedEvent(PluginStartedEvent event) {
        // do something.
    }

See #5339 (comment) for more.

Which issue(s) this PR fixes:

Fixes #5339 (comment)

Special notes for your reviewer:

  1. Create a plugin, add the listener above and write some logs
  2. Build and install the plugin
  3. Start plugin and see the logs you wrote

Does this PR introduce a user-facing change?

支持在插件中监听已启动事件

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen July 1, 2024 06:35
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.19%. Comparing base (bc10336) to head (70f5e17).
Report is 44 commits behind head on main.

Files Patch % Lines
...in/java/run/halo/app/plugin/HaloPluginManager.java 9.09% 10 Missing ⚠️
.../run/halo/app/plugin/event/PluginStartedEvent.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6234      +/-   ##
============================================
+ Coverage     54.51%   57.19%   +2.68%     
- Complexity     3523     3719     +196     
============================================
  Files           646      647       +1     
  Lines         21862    21974     +112     
  Branches       1528     1538      +10     
============================================
+ Hits          11917    12567     +650     
+ Misses         9328     8798     -530     
+ Partials        617      609       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link

f2c-ci-robot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3875251 into halo-dev:main Jul 1, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

插件支持刷新搜索索引
3 participants