Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to disable two-factor authentication #6242

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.17.0

What this PR does / why we need it:

This PR provides a configuration property to control whether two-factor authentication is disabled. e.g.:

halo:
  security:
    two-factor-auth:
      disabled: true | false # Default is false.

Which issue(s) this PR fixes:

Fixes #5640

Special notes for your reviewer:

  1. Enable 2FA and configure TOTP
  2. Disable 2FA by configuring property above
  3. Restart Halo and try to login

Does this PR introduce a user-facing change?

支持通过配置的方式全局禁用二步验证

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.0 milestone Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG July 1, 2024 09:30
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.00%. Comparing base (bc10336) to head (797583c).
Report is 52 commits behind head on main.

Files Patch % Lines
.../halo/app/infra/properties/SecurityProperties.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6242      +/-   ##
============================================
+ Coverage     54.51%   58.00%   +3.49%     
- Complexity     3523     3752     +229     
============================================
  Files           646      649       +3     
  Lines         21862    21995     +133     
  Branches       1528     1541      +13     
============================================
+ Hits          11917    12758     +841     
+ Misses         9328     8618     -710     
- Partials        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit cc3564b into halo-dev:main Jul 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

两步验证丢了怎么办
2 participants