-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to disable two-factor authentication #6242
Add support to disable two-factor authentication #6242
Conversation
Signed-off-by: JohnNiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6242 +/- ##
============================================
+ Coverage 54.51% 58.00% +3.49%
- Complexity 3523 3752 +229
============================================
Files 646 649 +3
Lines 21862 21995 +133
Branches 1528 1541 +13
============================================
+ Hits 11917 12758 +841
+ Misses 9328 8618 -710
- Partials 617 619 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.17.0
What this PR does / why we need it:
This PR provides a configuration property to control whether two-factor authentication is disabled. e.g.:
Which issue(s) this PR fixes:
Fixes #5640
Special notes for your reviewer:
Does this PR introduce a user-facing change?