Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bubble menu not appearing when crossing lines in editor #6268

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jul 4, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.18.x

What this PR does / why we need it:

在默认编辑器中,选中一个跨多个节点的 text 时,selection 会变为 RangeSelection,此时冒泡菜单将不会出现。

此 RP 将 RangeSelection 添加至 text 的冒泡菜单验证中,使得冒泡菜单可以出现。

How to test it?

测试跨行选中多个无序列表时,是否出现冒泡菜单。

Which issue(s) this PR fixes:

Fixes #6267

Does this PR introduce a user-facing change?

修复默认编辑器中跨行选择节点时冒泡菜单无法出现的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wzrove July 4, 2024 06:59
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.25%. Comparing base (bc10336) to head (db2477c).
Report is 69 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6268      +/-   ##
============================================
+ Coverage     54.51%   58.25%   +3.74%     
- Complexity     3523     3757     +234     
============================================
  Files           646      646              
  Lines         21862    21946      +84     
  Branches       1528     1542      +14     
============================================
+ Hits          11917    12784     +867     
+ Misses         9328     8543     -785     
- Partials        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
Copy link

f2c-ci-robot bot commented Jul 5, 2024

@ruibaby: The provided milestone is not valid for this repository. Milestones in this repository: [2.16.x, 2.17.x, 2.18.x, Backlog]

Use /milestone clear to clear the milestone.

In response to this:

/milestone release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby
Copy link
Member

ruibaby commented Jul 5, 2024

/cherry-pick release-2.17

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 0f01006 into halo-dev:main Jul 5, 2024
7 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #6283

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Jul 5, 2024
…editor (#6283)

This is an automated cherry-pick of #6268

/assign ruibaby

```release-note
修复默认编辑器中跨行选择节点时冒泡菜单无法出现的问题
```
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在编辑器中同时选中多段节点,冒泡菜单不出现
4 participants