Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove IP address judgment for device management #6275

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 5, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.18.x

What this PR does / why we need it:

设备管理去除 IP 地址检查以避免频繁登录

Does this PR introduce a user-facing change?

设备管理去除 IP 地址检查以避免频繁登录

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG July 5, 2024 08:36
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.31%. Comparing base (bc10336) to head (3243cde).
Report is 65 commits behind head on main.

Files Patch % Lines
...un/halo/app/security/device/DeviceServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6275      +/-   ##
============================================
+ Coverage     54.51%   58.31%   +3.80%     
- Complexity     3523     3762     +239     
============================================
  Files           646      647       +1     
  Lines         21862    21950      +88     
  Branches       1528     1540      +12     
============================================
+ Hits          11917    12801     +884     
+ Misses         9328     8531     -797     
- Partials        617      618       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member

/cherrypick release-2.17

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
Copy link

f2c-ci-robot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 36bc461 into halo-dev:main Jul 5, 2024
7 checks passed
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #6279

In response to this:

/cherrypick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Jul 5, 2024
…ment (#6279)

This is an automated cherry-pick of #6275

/assign JohnNiang

```release-note
设备管理去除 IP 地址检查以避免频繁登录
```
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants