Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve potential exception during bulk image upload in post creation #6276

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: resolve potential exception during bulk image upload in post creation #6276

merged 1 commit into from
Jul 5, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 5, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.18.x

What this PR does / why we need it:

修复创建文章前批量上传图片可能出现异常的问题。

目前解决方案为：移除上传前创建文章的逻辑，因为在上传前已经确定了文章的 metadata.name。

Does this PR introduce a user-facing change?

修复创建文章前批量上传图片可能出现异常的问题。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove July 5, 2024 08:46
@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.28%. Comparing base (bc10336) to head (cafe315).
Report is 68 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6276      +/-   ##
============================================
+ Coverage     54.51%   58.28%   +3.77%     
- Complexity     3523     3760     +237     
============================================
  Files           646      647       +1     
  Lines         21862    21953      +91     
  Branches       1528     1541      +13     
============================================
+ Hits          11917    12796     +879     
+ Misses         9328     8539     -789     
- Partials        617      618       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Copy link
Member Author

ruibaby commented Jul 5, 2024

/cherry-pick release-2.17

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LIlGG
LIlGG approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
guqing
guqing approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@guqing guqing merged commit ed5f9ae into halo-dev:main Jul 5, 2024
5 of 7 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #6282

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Jul 5, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Jul 5, 2024
@halo-dev-bot
[release-2.17] fix: resolve potential exception during bulk image upl…
34f789e 
…oad in post creation (#6282)

This is an automated cherry-pick of #6276

/assign ruibaby

```release-note
修复创建文章前批量上传图片可能出现异常的问题。
```
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing approved these changes

@LIlGG LIlGG LIlGG approved these changes

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@wzrove wzrove Awaiting requested review from wzrove

Assignees

@LIlGG LIlGG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ruibaby @halo-dev-bot @LIlGG @guqing