Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.17] chore: mark deprecated constructor for base plugin #6281

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 5, 2024

What type of PR is this?

/milestone 2.17.x

What this PR does / why we need it:

将 BasePlugin 的 PluginWrapper 构造函数标记为过时并输出警告日志提示

Does this PR introduce a user-facing change?

在 BasePlugin 的 PluginWrapper 构造函数输出过时警告日志以提醒开发者尽快适配

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby July 5, 2024 10:09
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-2.17@1cbc9c4). Learn more about missing BASE report.

Files Patch % Lines
.../src/main/java/run/halo/app/plugin/BasePlugin.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.17    #6281   +/-   ##
===============================================
  Coverage                ?   58.06%           
  Complexity              ?     3757           
===============================================
  Files                   ?      649           
  Lines                   ?    22020           
  Branches                ?     1546           
===============================================
  Hits                    ?    12785           
  Misses                  ?     8616           
  Partials                ?      619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang JohnNiang changed the title chore: mark deprecated constructor for base plugin [release-2.17] chore: mark deprecated constructor for base plugin Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 7292bd7 into halo-dev:release-2.17 Jul 5, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.1 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants