Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond 404 for non-exist theme resources instead of 500 #6340

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.18.x

What this PR does / why we need it:

This PR checks readable of theme resources while getting resources to prevent Halo from throwing FileNotFoundException.

Which issue(s) this PR fixes:

Fixes #6338

Special notes for your reviewer:

  1. Try to request https://www.halo.run/themes/fake-theme/assets/favicons/favicon-32x32.png
  2. See the result

Does this PR introduce a user-facing change?

修复访问不存在的主题资源时出现服务器异常的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 17, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 17, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG July 17, 2024 03:15
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.34%. Comparing base (bc10336) to head (e64e75e).
Report is 79 commits behind head on main.

Files Patch % Lines
.../halo/app/theme/config/ThemeWebFluxConfigurer.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6340      +/-   ##
============================================
+ Coverage     54.51%   58.34%   +3.83%     
- Complexity     3523     3763     +240     
============================================
  Files           646      646              
  Lines         21862    21977     +115     
  Branches       1528     1546      +18     
============================================
+ Hits          11917    12822     +905     
+ Misses         9328     8534     -794     
- Partials        617      621       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member Author

/cherrypick release-2.17

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
Copy link

f2c-ci-robot bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 1992916 into halo-dev:main Jul 22, 2024
7 checks passed
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #6355

In response to this:

/cherrypick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Jul 22, 2024
…00 (#6355)

This is an automated cherry-pick of #6340

/assign JohnNiang

```release-note
修复访问不存在的主题资源时出现服务器异常的问题
```
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal server error occurs while requesting a static resource which is not exist
3 participants