-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respond 404 for non-exist theme resources instead of 500 #6340
Respond 404 for non-exist theme resources instead of 500 #6340
Conversation
Signed-off-by: JohnNiang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6340 +/- ##
============================================
+ Coverage 54.51% 58.34% +3.83%
- Complexity 3523 3763 +240
============================================
Files 646 646
Lines 21862 21977 +115
Branches 1528 1546 +18
============================================
+ Hits 11917 12822 +905
+ Misses 9328 8534 -794
- Partials 617 621 +4 ☔ View full report in Codecov by Sentry. |
/cherrypick release-2.17 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JohnNiang: new pull request created: #6355 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area core
/milestone 2.18.x
What this PR does / why we need it:
This PR checks readable of theme resources while getting resources to prevent Halo from throwing FileNotFoundException.
Which issue(s) this PR fixes:
Fixes #6338
Special notes for your reviewer:
Does this PR introduce a user-facing change?