Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the first line indent to the Tab shortcut key #6388

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jul 26, 2024

What type of PR is this?

/kind feature
/area editor

What this PR does / why we need it:

支持在默认编辑器中使用 Tab 键实现首行缩进的功能。

当光标处于文本首行时,按下 Tab 键会触发首行缩进。
在首行缩进的情况下或者选中一段文本,再次按下 Tab 键会触发整段缩进。

How to test it?

测试文本块及区域标题块首行按下 Tab 键是否可以正常触发首行缩进

Which issue(s) this PR fixes:

Fixes #6316

Does this PR introduce a user-facing change?

默认编辑器增加 Tab 快捷键首行缩进功能

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from wan92hen and wzrove July 26, 2024 09:20
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jul 26, 2024
Copy link

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.34%. Comparing base (bc10336) to head (2b730ac).
Report is 86 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6388      +/-   ##
============================================
+ Coverage     54.51%   58.34%   +3.83%     
- Complexity     3523     3766     +243     
============================================
  Files           646      646              
  Lines         21862    21989     +127     
  Branches       1528     1546      +18     
============================================
+ Hits          11917    12829     +912     
+ Misses         9328     8538     -790     
- Partials        617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 59b3f46 into halo-dev:main Jul 29, 2024
8 checks passed
@ruibaby ruibaby added this to the 2.18.0 milestone Jul 29, 2024
@LIlGG LIlGG deleted the pref/first-line-indent branch August 22, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化默认编辑器 Tab 使其支持首行缩进
3 participants