Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the number of queried attachments in the selector modal #6402

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 29, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.18.x

What this PR does / why we need it:

修改附件选择组件的默认显示数量,以解决因为图片数量过多或者图片过大导致的卡顿问题。

Which issue(s) this PR fixes:

Ref #6352

Does this PR introduce a user-facing change?

修改附件选择组件的默认显示数量,以解决因为图片数量过多或者图片过大导致的卡顿问题。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wzrove July 29, 2024 03:36
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jul 29, 2024
@ruibaby ruibaby requested review from JohnNiang, LIlGG and guqing and removed request for Aanko and wzrove July 29, 2024 03:36
Copy link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.34%. Comparing base (bc10336) to head (2e8966f).
Report is 88 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6402      +/-   ##
============================================
+ Coverage     54.51%   58.34%   +3.83%     
- Complexity     3523     3766     +243     
============================================
  Files           646      646              
  Lines         21862    21989     +127     
  Branches       1528     1546      +18     
============================================
+ Hits          11917    12829     +912     
+ Misses         9328     8538     -790     
- Partials        617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link

f2c-ci-robot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit c551910 into halo-dev:main Jul 29, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants