Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list items require multiple backspace presses to delete #6408

Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jul 29, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.18.x

What this PR does / why we need it:

目前当编辑器中列表内容为空时,需要按退格键多次才能删除掉此列表内容。

本 PR 在执行单行删除逻辑之前,会检查列表是否处于活动状态,如果是则不再执行单行删除的逻辑。列表会执行 ListKeyMap 相关快捷键。

How to test it?

  1. 在默认富文本键入一个列表。
  2. 使用退格键删除这个列表。
  3. 查看是否可以一次就删除。

Which issue(s) this PR fixes:

Fixes #6389

Does this PR introduce a user-facing change?

修复默认编辑器中列表项需要按多次退格键才可以删除的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang July 29, 2024 09:01
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby July 29, 2024 09:01
Copy link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.32%. Comparing base (bc10336) to head (7a47685).
Report is 92 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6408      +/-   ##
============================================
+ Coverage     54.51%   58.32%   +3.81%     
- Complexity     3523     3766     +243     
============================================
  Files           646      646              
  Lines         21862    21989     +127     
  Branches       1528     1546      +18     
============================================
+ Hits          11917    12826     +909     
+ Misses         9328     8540     -788     
- Partials        617      623       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit fae5bf7 into halo-dev:main Jul 29, 2024
8 checks passed
@JohnNiang
Copy link
Member

/cherrypick release-2.17

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #6410

In response to this:

/cherrypick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 29, 2024
f2c-ci-robot bot pushed a commit that referenced this pull request Jul 29, 2024
…delete (#6410)

This is an automated cherry-pick of #6408

/assign JohnNiang

```release-note
修复默认编辑器中列表项需要按多次退格键才可以删除的问题
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器列表需要多次按退格键才能将其移除
5 participants