-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make comment and reply list item operations extendable #6438
feat: make comment and reply list item operations extendable #6438
Conversation
@chengzhongxue: You must be a member of the halo-dev/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ui/console-src/modules/contents/comments/components/CommentListItem.vue
Outdated
Show resolved
Hide resolved
@chengzhongxue 感谢参与贡献,在合并之前需要先签署一下我们的 CLA。 |
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6438 +/- ##
============================================
+ Coverage 54.51% 58.08% +3.57%
- Complexity 3523 3767 +244
============================================
Files 646 651 +5
Lines 21862 22106 +244
Branches 1528 1555 +27
============================================
+ Hits 11917 12841 +924
+ Misses 9328 8641 -687
- Partials 617 624 +7 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind feature
/milestone 2.18.x
What this PR does / why we need it:
评论和回复管理列表项的操作按钮支持被插件扩展。
Which issue(s) this PR fixes:
Fixes #6392
Special notes for your reviewer:
需要评论和回复的关于列表的已有功能是否正常。
如果需要测试扩展点是否有效,可以使用此插件测试:plugin-starter-1.0.0-SNAPSHOT.jar.zip
Does this PR introduce a user-facing change?