Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering search result by types, ownerNames, categoryNames and tagNames #6442

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core

What this PR does / why we need it:

This PR allows users to filter search result by types, owner names, category names and tag names.

Does this PR introduce a user-facing change?

完善搜索引擎过滤功能

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core labels Aug 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen August 5, 2024 09:56
Copy link

sonarqubecloud bot commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.27%. Comparing base (bc10336) to head (9a9f8e5).
Report is 105 commits behind head on main.

Files Patch % Lines
...run/halo/app/search/lucene/LuceneSearchEngine.java 68.75% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6442      +/-   ##
============================================
+ Coverage     54.51%   58.27%   +3.76%     
- Complexity     3523     3781     +258     
============================================
  Files           646      651       +5     
  Lines         21862    22138     +276     
  Branches       1528     1555      +27     
============================================
+ Hits          11917    12900     +983     
+ Misses         9328     8616     -712     
- Partials        617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
Copy link

f2c-ci-robot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 4038655 into halo-dev:main Aug 8, 2024
8 checks passed
@JohnNiang JohnNiang deleted the feat/support-includes-for-search-engine branch August 8, 2024 05:31
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants