Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saving settings in theme preview returns to homepage #6447

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 7, 2024

What type of PR is this?

/kind bug
/area ui
/milestone 2.19.x

What this PR does / why we need it:

此 PR 将主题预览及文章预览的 iframe 由 srcdoc 改为使用 src 加载。用于解决在主题预览时,如果点击保存设置,会导致主题端页面跳转至首页。

How to test it?

  1. 打开主题预览界面。
  2. 打开非首页的页面。
  3. 点击保存配置。查看此时刷新页面后是否不再回到首页。

同时需要测试 #4047 中的场景是否还会再发生。

Which issue(s) this PR fixes:

Fixes #6371

Does this PR introduce a user-facing change?

解决预览主题时保存设置,页面会跳转至首页的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and wzrove August 7, 2024 09:24
@LIlGG LIlGG requested review from JohnNiang, ruibaby and guqing and removed request for lan-yonghui and wzrove August 7, 2024 09:25
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.12%. Comparing base (bc10336) to head (623bc43).
Report is 106 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6447      +/-   ##
============================================
+ Coverage     54.51%   58.12%   +3.61%     
- Complexity     3523     3767     +244     
============================================
  Files           646      651       +5     
  Lines         21862    22106     +244     
  Branches       1528     1555      +27     
============================================
+ Hits          11917    12850     +933     
+ Misses         9328     8633     -695     
- Partials        617      623       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 6cfc92b into halo-dev:main Aug 8, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

将主题预览功能中的 iframe 改为使用 src 加载
3 participants