-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: saving settings in theme preview returns to homepage #6447
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
============================================
+ Coverage 54.51% 58.12% +3.61%
- Complexity 3523 3767 +244
============================================
Files 646 651 +5
Lines 21862 22106 +244
Branches 1528 1555 +27
============================================
+ Hits 11917 12850 +933
+ Misses 9328 8633 -695
- Partials 617 623 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area ui
/milestone 2.19.x
What this PR does / why we need it:
此 PR 将主题预览及文章预览的
iframe
由 srcdoc 改为使用 src 加载。用于解决在主题预览时,如果点击保存设置,会导致主题端页面跳转至首页。How to test it?
同时需要测试 #4047 中的场景是否还会再发生。
Which issue(s) this PR fixes:
Fixes #6371
Does this PR introduce a user-facing change?