Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add full-screen support to code input #6453

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 9, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.19.x

What this PR does / why we need it:

Code 输入框支持全屏编辑。

image image

Which issue(s) this PR fixes:

Fixes #6308

Special notes for your reviewer:

需要在任意 Code 输入框中测试全屏功能是否正常。

Does this PR introduce a user-facing change?

Code 输入框支持全屏编辑。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Aug 9, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 9, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 9, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing August 9, 2024 04:59
Copy link

sonarqubecloud bot commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.19%. Comparing base (bc10336) to head (8c5c397).
Report is 111 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6453      +/-   ##
============================================
+ Coverage     54.51%   58.19%   +3.68%     
- Complexity     3523     3779     +256     
============================================
  Files           646      651       +5     
  Lines         21862    22138     +276     
  Branches       1528     1555      +27     
============================================
+ Hits          11917    12883     +966     
+ Misses         9328     8631     -697     
- Partials        617      624       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit c2ac19f into halo-dev:main Aug 13, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

设置 - 代码注入 - 编辑框 可以全屏输入
3 participants