-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add full-screen support to code input #6453
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6453 +/- ##
============================================
+ Coverage 54.51% 58.19% +3.68%
- Complexity 3523 3779 +256
============================================
Files 646 651 +5
Lines 21862 22138 +276
Branches 1528 1555 +27
============================================
+ Hits 11917 12883 +966
+ Misses 9328 8631 -697
- Partials 617 624 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind feature
/milestone 2.19.x
What this PR does / why we need it:
Code 输入框支持全屏编辑。
Which issue(s) this PR fixes:
Fixes #6308
Special notes for your reviewer:
需要在任意 Code 输入框中测试全屏功能是否正常。
Does this PR introduce a user-facing change?