-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use patch api to refactor menu drag-and-drop sorting feature #6462
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6462 +/- ##
============================================
+ Coverage 54.51% 58.27% +3.76%
- Complexity 3523 3781 +258
============================================
Files 646 651 +5
Lines 21862 22138 +276
Branches 1528 1555 +27
============================================
+ Hits 11917 12900 +983
+ Misses 9328 8616 -712
- Partials 617 622 +5 ☔ View full report in Codecov by Sentry. |
@halo-dev/sig-halo 请帮忙检查一下 role template 是否加了 patch 类型的接口。 |
当只分配了菜单管理而没有系统配置权限时,菜单管理页面会因为 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
works very well
权限正确 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind improvement
/milestone 2.19.x
What this PR does / why we need it:
使用 patch 接口重构菜单项拖动排序等功能。
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
需要测试菜单项的拖动排序功能是否符合预期。
Does this PR introduce a user-facing change?