Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve part of the page operation logic using the patch api #6463

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 12, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.19.x

What this PR does / why we need it:

使用 patch 接口重构页面的删除、可见性修改等逻辑。

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

测试页面删除、可见性修改功能是否符合预期。

Does this PR introduce a user-facing change?

使用 patch 接口重构页面的删除、可见性修改等逻辑。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG August 12, 2024 05:05
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Aug 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove August 12, 2024 05:05
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (bc10336) to head (fba4deb).
Report is 110 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6463      +/-   ##
============================================
+ Coverage     54.51%   58.27%   +3.76%     
- Complexity     3523     3781     +258     
============================================
  Files           646      651       +5     
  Lines         21862    22138     +276     
  Branches       1528     1555      +27     
============================================
+ Hits          11917    12900     +983     
+ Misses         9328     8616     -712     
- Partials        617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
Copy link

f2c-ci-robot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ddd5968 into halo-dev:main Aug 13, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants