-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prompt for users to reload page after plugin update #6470
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6470 +/- ##
============================================
+ Coverage 54.51% 58.27% +3.76%
- Complexity 3523 3783 +260
============================================
Files 646 651 +5
Lines 21862 22139 +277
Branches 1528 1555 +27
============================================
+ Hits 11917 12902 +985
+ Misses 9328 8613 -715
- Partials 617 624 +7 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…reloaded (#6498) #### What type of PR is this? /area ui /kind improvement /milestone 2.19.x #### What this PR does / why we need it: 优化插件是否需要重载页面的判断条件,否则从低版本升级到 2.19 时,所有插件都会提示需要重载。 因为在 #6470 中修改了 bundle.js 的结构,但升级到 2.19 之后可能并不会及时抛弃 bundle.js 的缓存,因为插件本身的 version 并没有改变,bundle.js 的 hash 参数也不会改变。 #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/kind improvement
/area core
/milestone 2.19.x
What this PR does / why we need it:
支持在插件变动之后(版本更新或者安装启用),提示使用者重载页面。
后端改变了插件 bundle.js 中关于启用插件信息的结构以便在插件升级后检测是否加载。
Which issue(s) this PR fixes:
Fixes #4464
Does this PR introduce a user-facing change?