Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prompt for users to reload page after plugin update #6470

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 15, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.19.x

What this PR does / why we need it:

支持在插件变动之后(版本更新或者安装启用),提示使用者重载页面。

image

后端改变了插件 bundle.js 中关于启用插件信息的结构以便在插件升级后检测是否加载。

Which issue(s) this PR fixes:

Fixes #4464

Does this PR introduce a user-facing change?

支持在插件变动之后(版本更新或者首次启用),提示使用者重载页面。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/core Issues or PRs related to the Halo Core labels Aug 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen August 15, 2024 08:18
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.27%. Comparing base (bc10336) to head (d19c27b).
Report is 117 commits behind head on main.

Files Patch % Lines
...core/extension/service/impl/PluginServiceImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6470      +/-   ##
============================================
+ Coverage     54.51%   58.27%   +3.76%     
- Complexity     3523     3783     +260     
============================================
  Files           646      651       +5     
  Lines         21862    22139     +277     
  Branches       1528     1555      +27     
============================================
+ Hits          11917    12902     +985     
+ Misses         9328     8613     -715     
- Partials        617      624       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby changed the title refactor: rename and restructure enabled plugins in bundle.js feat: add prompt for users to reload page after plugin update Aug 15, 2024
@ruibaby ruibaby marked this pull request as ready for review August 15, 2024 09:30
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove August 15, 2024 09:30
Copy link

@ruibaby ruibaby added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Aug 15, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang JohnNiang merged commit 10e3f57 into halo-dev:main Aug 16, 2024
7 of 8 checks passed
Copy link

f2c-ci-robot bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@guqing guqing deleted the refactor/4464 branch August 16, 2024 02:50
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 16, 2024
f2c-ci-robot bot pushed a commit that referenced this pull request Aug 23, 2024
…reloaded (#6498)

#### What type of PR is this?

/area ui
/kind improvement
/milestone 2.19.x

#### What this PR does / why we need it:

优化插件是否需要重载页面的判断条件,否则从低版本升级到 2.19 时,所有插件都会提示需要重载。

因为在 #6470 中修改了 bundle.js 的结构,但升级到 2.19 之后可能并不会及时抛弃 bundle.js 的缓存,因为插件本身的 version 并没有改变,bundle.js 的 hash 参数也不会改变。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在插件管理中添加重载页面提示
3 participants