Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add H2 database usage warning to setup page #6502

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 23, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.19.x

What this PR does / why we need it:

在初始化页面添加使用 H2 数据库的警告。

image

Special notes for your reviewer:

需要测试在首次安装的时候使用 H2 数据库时,初始化页面是否有警告界面。

Does this PR introduce a user-facing change?

在初始化页面添加使用 H2 数据库的警告。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Aug 23, 2024
Copy link

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (6cd8dc8) to head (5a785a4).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6502      +/-   ##
============================================
+ Coverage     58.18%   58.22%   +0.04%     
- Complexity     3774     3775       +1     
============================================
  Files           651      651              
  Lines         22125    22128       +3     
  Branches       1538     1538              
============================================
+ Hits          12873    12885      +12     
+ Misses         8641     8634       -7     
+ Partials        611      609       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仅在初始化页面提示似乎无法通知到目前正在使用 H2 的用户。

@ruibaby
Copy link
Member Author

ruibaby commented Aug 26, 2024

仅在初始化页面提示似乎无法通知到目前正在使用 H2 的用户。

不管了。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3767a5a into halo-dev:main Aug 26, 2024
8 checks passed
@ruibaby ruibaby deleted the feat/add-h2-alert-for-setup-page branch August 26, 2024 02:35
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants