-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add H2 database usage warning to setup page #6502
feat: add H2 database usage warning to setup page #6502
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6502 +/- ##
============================================
+ Coverage 58.18% 58.22% +0.04%
- Complexity 3774 3775 +1
============================================
Files 651 651
Lines 22125 22128 +3
Branches 1538 1538
============================================
+ Hits 12873 12885 +12
+ Misses 8641 8634 -7
+ Partials 611 609 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
仅在初始化页面提示似乎无法通知到目前正在使用 H2 的用户。
不管了。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind improvement
/milestone 2.19.x
What this PR does / why we need it:
在初始化页面添加使用 H2 数据库的警告。
Special notes for your reviewer:
需要测试在首次安装的时候使用 H2 数据库时,初始化页面是否有警告界面。
Does this PR introduce a user-facing change?